Uploaded image for project: 'Pax Tinybundles'
  1. Pax Tinybundles
  2. PAXTB-8

TinyBundles overrides Import-Package instruction when building with Bnd

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      It is not possible to provide a custom instruction for Import-Package when using the Bnd-builder, because it will overwrite anything a user provides with "*". The responsible code is in the function BndBuilder.checkMandatoryProperties, line 168:

      analyzer.setProperty( Analyzer.IMPORT_PACKAGE, "*" );
      

      Is there any reason this line cannot simply be dropped to let the user take the responsibility for supplying the correct instruction here?

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            tonit Toni Menzel added a comment -

            usually this setting can be overwritten by a subsequent call to analyzer.setProperty( Analyzer.IMPORT_PACKAGE, MYIMPORTS );

            Show
            tonit Toni Menzel added a comment - usually this setting can be overwritten by a subsequent call to analyzer.setProperty( Analyzer.IMPORT_PACKAGE, MYIMPORTS );
            Hide
            bjoernpollex Björn Pollex added a comment -

            But from user-code there is no subsequent call. This all happens inside the bundle().build(withBnd()-call, which produces the final bundle.

            Show
            bjoernpollex Björn Pollex added a comment - But from user-code there is no subsequent call. This all happens inside the bundle().build(withBnd() -call, which produces the final bundle.
            Hide
            bjoernpollex Björn Pollex added a comment -

            I am currently looking into a solution for this issue, and am a bit confused. There seem to be several critical lines commented out in BndBuilder, and I cannot figure out why (or who did it, the history seems all screwed up). Does anyone know why this was done? If not, I am simply going to write tests for this issue, and see that I don't break existing tests

            Show
            bjoernpollex Björn Pollex added a comment - I am currently looking into a solution for this issue, and am a bit confused. There seem to be several critical lines commented out in BndBuilder , and I cannot figure out why (or who did it, the history seems all screwed up). Does anyone know why this was done? If not, I am simply going to write tests for this issue, and see that I don't break existing tests
            Hide
            giamma gianmaria romanato added a comment -

            Any news about this issue?

            Show
            giamma gianmaria romanato added a comment - Any news about this issue?
            Hide
            dale.peakall Dale Peakall added a comment -

            Fix for this is trivial - any chance of a fix & release?

            Show
            dale.peakall Dale Peakall added a comment - Fix for this is trivial - any chance of a fix & release?

              People

              • Assignee:
                tonit Toni Menzel
                Reporter:
                bjoernpollex Björn Pollex
              • Votes:
                1 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Development